target: tizenrt-artik05x: Initial porting #1775
Conversation
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, | ||
| # either express or implied. See the License for the specific | ||
| # language governing permissions and limitations under the License. |
There was a problem hiding this comment.
Is it possible to combine the first two licenses?
There was a problem hiding this comment.
I think both license are necessary although it is same Apache license, because the Makefile comes from TizenRT source and we usually keep the original license.
| static void | ||
| print_help (char *name) | ||
| { | ||
| jerry_port_console ("Usage: %s [OPTION]... [FILE]...\n" |
There was a problem hiding this comment.
The jerry_port_console is planned to be phased out from the project. I would recommend to use printf.
There was a problem hiding this comment.
Ok. I will get rids of it.
There was a problem hiding this comment.
I tried to remove jerry_port_console beforehand. However, jerry-core/ecma/builtin-objects/ecma-builtin-global.c uses jerry_port_console. Perhaps I can remove jerry_port_console after #1749 is merged.
| int | ||
| setjmp (jmp_buf buf) | ||
| { | ||
| return __builtin_setjmp (buf); |
There was a problem hiding this comment.
The __builtin_setjmp implementation is incorrect on NuttX. I would recommend to use the solution from the NuttX port and add an assembly file for it.
There was a problem hiding this comment.
Thank you for informing me. setjmp/longjmp implementation on NuttX is not yet checked correctly working in tizenrt-artik05x. I had a plan to make another patch. The next patch will contains like followings:
- Integrating
longjmp/setjmpfrom NuttX port (after confirming correctly working on TizenRT) - Adapting incoming breaking changes (e.g., removing
jerry_port_console,PORT_DIR, ...)
...
|
Please check #1776 and #1777 |
Initial porting to tizenrt-artik05x. Tizen RT is a lightweight RTOS-based platform to support low-end IoT devices. The project is under developing in github TizenRt repo. Artik05x is an IoT SoC solution that will be released soon. This PR contains the minimum porting that can print Hello world from jerryscript and a document for building and running. I used jerry_port.c and jerry_main.c in nuttx port and default port for porting base code. Also I used Make.defs and Makefile in working example in tizenrt for adding jerryscript configuration. JerryScript-DCO-1.0-Signed-off-by: Sanggyu Lee [email protected]
|
@LaszloLango I rebased since #1777 landed. |
|
Sorry for the late review, but cannot find |
|
Alas, It's initial porting. he will ramp up the Tizen RT features. :p |
|
Fine. I was just puzzled as |
|
@akosthekiss Oh. It's my mistake! After moving |
Initial porting to tizenrt-artik05x.
Tizen RT is a lightweight RTOS-based platform to support low-end IoT devices.
The project is under developing in github TizenRt repo.
Artik05x is an IoT SoC solution that will be released soon.
This PR contains the minimum porting that can print Hello
world from jerryscript and a document for building and running.
I used jerry_port.c and jerry_main.c in nuttx port and default port for
porting base code. Also I used Make.defs and Makefile in working
example in tizenrt for adding jerryscript configuration.
JerryScript-DCO-1.0-Signed-off-by: Sanggyu Lee [email protected]