Skip to content

Increase verbosity when breakpoints not found in HTML (JavaScript) Debugger client #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2017

Conversation

polaroi8d
Copy link
Contributor

In the Python Client if users try to add breakpoint in a wrong index, the client warn them, "Breakpoint not found". Add this defect to the HTML ( JavaScript ) client too.

JerryScript-DCO-1.0-Signed-off-by: Levente Orban [email protected]

JerryScript-DCO-1.0-Signed-off-by: Levente Orban [email protected]
@polaroi8d polaroi8d changed the title Increase verbosity when breakpoints not found in HTML client Increase verbosity when breakpoints not found in HTML (JavaScript) Debugger client May 12, 2017
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka
Copy link
Contributor

LGTM (informally)

Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit 0066e52 into jerryscript-project:master May 12, 2017
@polaroi8d polaroi8d deleted the found_break branch May 12, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants