Rework argument parsing. #1896
Merged
Rework argument parsing. #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
rework_arg_parse
branch
from
8c27fed to
051f370
Compare
LaszloLango
requested changes
Jun 29, 2017
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (cli_state.error != NULL) | ||
| { | ||
| if (cli_state.arg != NULL) |
zherczeg
force-pushed
the
rework_arg_parse
branch
from
051f370 to
f0bec0e
Compare
LaszloLango
approved these changes
Jun 30, 2017
jerry-main/cli.c
Outdated
| * Checks whether the current argument is an option. | ||
| * | ||
| * Note: | ||
| * The state->error is not NULL on error and it contans the error message. |
jerry-main/cli.c
Outdated
| * string and its arguments are available via state->arg[0..].) | ||
| * CLI_OPT_END signals that all command line arguments are consumed. | ||
| * Note: | ||
| * The state->error is not NULL on error and it contans the error message. |
Heavily simplify the interface of CLI. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
rework_arg_parse
branch
from
f0bec0e to
cb61cf3
Compare
|
Thanks, fixed. |
|
LGTM |
ossy-szeged
added a commit
to ossy-szeged/jerryscript
that referenced
this pull request
Nov 29, 2019
REPL could read JS file from standard input when we passed "-" option, but after jerryscript-project#1896 "-" became invalid option mistakenly. JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác [email protected]
rerobika
pushed a commit
that referenced
this pull request
Nov 29, 2019
REPL could read JS file from standard input when we passed "-" option, but after #1896 "-" became invalid option mistakenly. JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily simplify the interface of CLI.