Modify the build method of NuttX target. #2154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtakacs
force-pushed
the
modify-nuttx-target-build
branch
from
2755a91 to
eadc6f7
Compare
|
I think it is a good approach to use CMake to build jerryscript. Could you please check #2103, and also update the NuttX related parts? |
rtakacs
force-pushed
the
modify-nuttx-target-build
branch
from
eadc6f7 to
d998677
Compare
|
@robertsipka Thanks for your comment. I've updated the README.md based on #2103 NuttX part. |
robertsipka
reviewed
Dec 28, 2017
targets/nuttx-stm32f4/README.md
Outdated
| sudo apt-get install gperf flex bison libncurses-dev | ||
|
|
||
| # Assuming you are in jerry-nuttx folder. | ||
| git clone https://github.com/jameswalmsley/kconfig-frontends.git |
There was a problem hiding this comment.
As akosthekiss mentioned in #2103, the nuttx/tools repo contains its own kconfig sources. I think that cloning the https://bitbucket.org/nuttx/tools.git would be better.
There was a problem hiding this comment.
@robertsipka Sorry, I missed that :) I will modify the README.md file.
|
I think this can land after a few minor changes. |
rtakacs
force-pushed
the
modify-nuttx-target-build
branch
from
d998677 to
f3aa2c4
Compare
Modified the Makefile of the NuttX target to build only the application file (targets/nuttx-stm32f4/jerry-main.c) and not the whole project. It helps to build JerryScript separately and use the static libs when building NuttX. Also modified the README.md to describe the new build process. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs [email protected]
rtakacs
force-pushed
the
modify-nuttx-target-build
branch
from
f3aa2c4 to
10f58e6
Compare
|
@zherczeg @robertsipka Okay, I've updated the README.md with all the missing information that are mentioned in #2103. |
|
LGTM (informally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, NuttX compiles the whole JerryScript (with the target app) by the targets/nuttx-stm32f4/Makefile. I think, this is not the best because there are many compile/feature-options (in build.py) that are not supported neither in Makefile nor in KConfig.
This development helps to build JerryScript separately from NuttX. In this case it's simple enough just build the target app (targets/nuttx-stm32f4/jerry-main.c) by NuttX and use the JerryScript's static libraries.
The compile/feature-options maintenance could be better because it doesn't need to duplicate them in the Makefile and in the KConfig files.