Fix random number generation on ESP8266 #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
reviewed
Jan 3, 2018
targets/esp8266/user/jerry_extapi.c
Outdated
| double number = jerry_get_number_value (args_p[cc]); | ||
| if ((int) number == number) | ||
| { | ||
| printf ("%d", number); |
There was a problem hiding this comment.
Does not this cause a warning here? Is it print a correct number at all? Not just rubbish?
There was a problem hiding this comment.
I tested it, and it caused an issue. Thanks for your suggestion, I'm going to fix it.
There was a problem hiding this comment.
Fixed, now it works as intended.
This patch uses the onboard RTC for generating random seed. It also improves the print handler to support float values. The rom segment is slightly increased to fit to the latest master. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
|
LGTM (informally) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the onboard RTC for generating random seed. It also improves the print handler to support float values.
The rom segment is slightly increased to fit to the latest master.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]