Add version fields for debugger configuration #2166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
added
enhancement
zherczeg
reviewed
Jan 17, 2018
jerry-core/debugger/debugger.h
Outdated
| /** | ||
| * JerryScript debugger protocol version. | ||
| */ | ||
| #define JERRY_DEBUGGER_VERSION (4) |
There was a problem hiding this comment.
I would start with 1 if that's not a problem for you (zero is not really a version number imho).
galpeter
force-pushed
the
debugger-versioning
branch
from
9b95d20 to
8db685d
Compare
By adding version information to the debugger protocol it is possible to report if the debugger client and server have different expectations on debugger workings (opcodes, types, etc.). JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
force-pushed
the
debugger-versioning
branch
from
8db685d to
1e63685
Compare
|
LGTM (informally) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding version information to the debugger protocol
it is possible to report if the debugger client and server
have different expectations on debugger workings (opcodes, types, etc.).