Print the return value of the engine in case of TizenRT. #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (informally) |
zherczeg
approved these changes
Jan 23, 2018
| int ret_code = jerry_cmd_main(argc, argv); | ||
|
|
||
| #ifdef CONFIG_DEBUG_VERBOSE | ||
| printf("JerryScript Result: %d\n", ret_code); |
There was a problem hiding this comment.
@rtakacs What about jerry_port_log, insted of printf?
There was a problem hiding this comment.
@glistening Good idea, thanks.
@zherczeg Fixed.
Since TizenRT doesn't have any commands to get the return value of a process, added a debug print line that shows the return value. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs [email protected]
rtakacs
force-pushed
the
tizenrt-verbose-print
branch
from
bba10d5 to
e9ca9d4
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since TizenRT doesn't have any commands to get the return value of a process,
added a debug print line that shows the return value.
Similar solution was introduced in IoT.js (iotjs_main_tizenrt.c#L167)