Reduce the memory footprint of 'ecma_instantiate_builtin' #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
reviewed
Feb 22, 2018
| /** | ||
| * Helper function for 'ecma_instantiate_builtin' | ||
| */ | ||
| static void ecma_instantiate_builtin_helper (ecma_builtin_id_t builtin_id, /**< built-in id */ |
There was a problem hiding this comment.
put a newline after static void
JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
|
LGTM (informally) |
grgustaf
pushed a commit
to grgustaf/jerryscript
that referenced
this pull request
Mar 19, 2018
…t-project#2218) JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]