Revisit unused global functions in jerry-core

[akosthekiss]

There are some leftover global functions in the code that are not
referenced at all anymore. These functions are removed by this
patch.

There are also some global functions that are only used in their
own modules. These functions are made static by this patch.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

[akosthekiss]

Unused global functions (removed):

• ecma_alloc_getter_setter_pointers
• ecma_dealloc_getter_setter_pointers
• ecma_raise_eval_error
• lit_char_is_format_control

Global functions unused outside their modules (made static):

• ecma_builtin_helper_json_create_separated_properties
• ecma_new_ecma_string_from_magic_string_ex_id
• ecma_number_get_fraction_and_exponent
• ecma_number_make_normal_positive_from_fraction_and_exponent
• ecma_op_object_get_property
• ecma_promise_get_result
• ecma_promise_get_state
• ecma_promise_set_result
• ecma_promise_set_state
• ecma_raise_standard_error
• jmem_stats_print
• lit_get_magic_string_size_block_start
• parser_send_breakpoints

For future reference, code used to find these functions:

tools/build.py --clean --debug --profile=es2015-subset --error-messages=on --snapshot-exec=on --snapshot-save=on --line-info=on --jerry-debugger=on --mem-stats=on --show-opcodes=on --show-regexp-opcodes=on
cd build/lib
nm libjerry-core.a | grep ' U ' | cut -d 'U' -f 2 | cut -d ' ' -f 2 | sort -u >core-referenced.txt
nm libjerry-core.a | grep ' T ' | cut -d 'T' -f 2 | cut -d ' ' -f 2 | sort -u >core-globals.txt 
comm -23 core-globals.txt core-referenced.txt | grep -v jerry_

[zherczeg]

LGTM

[zherczeg]

Still LGTM just squash commits.

[akosthekiss]

Commits squashed. (I've also edited my comment above listing the touched functions and the commands used to find them.)

[yichoi]

LGTM