Fix include directories of jerry-ext #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distinction between public and private include directories was not maintained and the install paths got confusing. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
|
The command to perform the install step (into a local directory): $ tools/build.py --clean --install=build/localThe way headers are installed with $ ls -1RF build/local/include
include/
jerryscript-compiler.h
jerryscript-core.h
jerryscript-debugger-transport.h
jerryscript-debugger.h
jerryscript-port-default.h
jerryscript-port.h
jerryscript-snapshot.h
jerryscript.h
jext-common.h
build/local/include/include:
jerryscript-ext/
build/local/include/include/jerryscript-ext:
arg.h
arg.impl.h
autorelease.h
autorelease.impl.h
debugger.h
handler.h
module.hThe way headers are installed with this PR: $ ls -1RF build/local/include
jerryscript-compiler.h
jerryscript-core.h
jerryscript-debugger-transport.h
jerryscript-debugger.h
jerryscript-ext/
jerryscript-port-default.h
jerryscript-port.h
jerryscript-snapshot.h
jerryscript.h
build/local/include/jerryscript-ext:
arg.h
arg.impl.h
autorelease.h
autorelease.impl.h
debugger.h
handler.h
module.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distinction between public and private include directories was
not maintained and the install paths got confusing.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]