Skip to content

Properly guard off LCache-related functionality #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

akosthekiss
Copy link
Member

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
@akosthekiss akosthekiss added the ecma core Related to core ECMA functionality label Sep 6, 2018
@akosthekiss
Copy link
Member Author

Tested with

tools/build.py --clean --compile-flag=-DCONFIG_ECMA_LCACHE_DISABLE
tools/run-tests.py --jerry-tests --buildoptions=--compile-flag=-DCONFIG_ECMA_LCACHE_DISABLE

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtakacs
Copy link
Contributor

rtakacs commented Sep 10, 2018

LGTM (informal)

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit 7825e47 into jerryscript-project:master Sep 10, 2018
@akosthekiss akosthekiss deleted the lcache-guard branch September 10, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecma core Related to core ECMA functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants