Add some progress printing to the test262 tests #2559
Conversation
|
I like this patch, but time to time we ran into the log limit on Travis CI. Fortunately it looks like this change does not reach the limit, because the bots are green. However it would be great to add a |
|
The commit is not properly signed, which makes the Travis CI fail. As long as the PR is red (i.e., some checks fail), it may get less attention from reviewers because they know that it will still certainly change. So, it's better to fix CI issues as early as possible. |
crazy2be
force-pushed
the
print-test262-progress
branch
from
1838b5d to
a8f6872
Compare
|
@akosthekiss: Oops, my bad! I didn't realize the CI builds were failing, thanks for the heads up :). @LaszloLango: If the logs become too long, you can also adjust the space between logs. Right now it is 100, which should print about 115 lines. If that became too many, you can make it 200, which would only print 58 lines. Otherwise I am not sure the best way to add such a quiet option to the bash script (do you already have such a system in place for other scripts?). |
| function progress_monitor() { | ||
| NUM_LINES_GOTTEN=0 | ||
| (>&2 echo) | ||
| while read line; do |
There was a problem hiding this comment.
Minor style issue: put the do on separate line
while read line
do| NUM_LINES_GOTTEN=0 | ||
| (>&2 echo) | ||
| while read line; do | ||
| if [[ $((NUM_LINES_GOTTEN % 100)) == 0 ]]; then |
There was a problem hiding this comment.
Minor style issue: put the then on a separate line
if [[ $((NUM_LINES_GOTTEN % 100)) == 0 ]]
then
| (>&2 echo -ne "\rExecuted approx ${NUM_LINES_GOTTEN} tests...") | ||
| fi | ||
| echo "$line" | ||
| NUM_LINES_GOTTEN=$((NUM_LINES_GOTTEN+1)) |
There was a problem hiding this comment.
Missing spaces around +:
NUM_LINES_GOTTEN=$((NUM_LINES_GOTTEN + 1))
crazy2be
force-pushed
the
print-test262-progress
branch
from
a8f6872 to
0efbcfd
Compare
Previously, these would run for several minutes without printing any progress. Now, at least print the number of tests executed. JerryScript-DCO-1.0-Signed-off-by: crazy2be [email protected]
crazy2be
force-pushed
the
print-test262-progress
branch
from
0efbcfd to
6eee0ab
Compare
Previously, these would run for several minutes without printing
any progress. Now, at least print the number of tests executed.