Skip to content

Fix floating number parsing. #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

zherczeg
Copy link
Member

This patches fixes floating point number parsing when the number starts with dot.

Fixes #2614.

This patches fixes floating point number parsing when the number starts with dot.

Fixes jerryscript-project#2614.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango added bug Undesired behaviour ecma core Related to core ECMA functionality labels Nov 30, 2018
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

@akosthekiss akosthekiss added the parser Related to the JavaScript parser label Dec 1, 2018
Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosthekiss akosthekiss merged commit bc1b13d into jerryscript-project:master Dec 1, 2018
@zherczeg zherczeg deleted the number_fix branch December 6, 2018 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour ecma core Related to core ECMA functionality parser Related to the JavaScript parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing code like ".5.toString(4)" will cause a error "identifier start after number"
4 participants