Implement Iterator interface and Array iterators #2640

rerobika · 2018-12-12T09:43:52Z

Related part of the standard: https://www.ecma-international.org/ecma-262/6.0/#sec-array-iterator-objects

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

jerry-core/ecma/operations/ecma-array-iterator-object.h

jerry-core/ecma/operations/ecma-array-iterator-object.c

jerry-core/ecma/operations/ecma-iterator-object.c

jerry-core/ecma/operations/ecma-array-iterator-object.c

zherczeg · 2019-01-09T13:34:08Z

Please add a test to var a = []; a.keys().toString();

zherczeg

LGTM after minor fix.

jerry-core/ecma/base/ecma-gc.c

zherczeg

LGTM

jerry-core/ecma/base/ecma-globals.h

jerry-core/ecma/base/ecma-gc.c

jerry-core/ecma/base/ecma-globals.h

jerry-core/ecma/builtin-objects/ecma-builtin-array-iterator-prototype.c

jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.c

jerry-core/ecma/builtin-objects/ecma-builtin-iterator-prototype.c

jerry-core/ecma/operations/ecma-iterator-object.c

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

rerobika · 2019-02-08T09:22:29Z

@LaszloLango Thanks for the review, I've updated the PR according to it.

LaszloLango

LGTM

galpeter · 2019-02-08T09:24:18Z

jerry-core/ecma/builtin-objects/ecma-builtin-array-iterator-prototype.c

+  ecma_object_t *array_object_p = ECMA_GET_POINTER (ecma_object_t,
+                                                    ext_obj_p->u.pseudo_array.u2.iterated_value_cp);
+
+


There is two newlines there. One is enough.

galpeter · 2019-02-08T09:32:11Z

jerry-core/ecma/builtin-objects/ecma-builtin-array-iterator-prototype.c

+  uint32_t length;
+
+  /* 8 - 9. */
+#ifndef CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN


I was wondering if this length query construct is used elsewhere (did not find any proof for it yet). IMHO this would make a good helper function which can return the length of an array/typedarray, but maybe in the future.

galpeter · 2019-02-08T09:33:30Z

jerry-core/ecma/builtin-objects/ecma-builtin-array-iterator-prototype.c

+
+    ecma_extended_object_t *ext_array_obj_p = (ecma_extended_object_t *) array_object_p;
+
+    length = ext_array_obj_p->u.array.length;


For an ordinary array shouldn't we access the length property? Like what would happen if there is an array created like this:

var arr = []; arr.length = 30;

And then doing iteration on this new array.

galpeter · 2019-02-08T09:36:42Z

jerry-core/ecma/builtin-objects/ecma-builtin-array-iterator-prototype.c

+  else
+  {
+#endif /* !CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN */
+    JERRY_ASSERT (ecma_get_object_type (array_object_p) == ECMA_OBJECT_TYPE_ARRAY);


What would happen if we are iterating over a function's arguments array? AFAIK that has a different type.

galpeter · 2019-02-08T09:38:06Z

jerry-core/ecma/builtin-objects/ecma-builtin-array-iterator-prototype.c

+  }
+
+  ecma_object_t *obj_p = ecma_get_object_from_value (this_val);
+  ecma_extended_object_t *ext_obj_p = (ecma_extended_object_t *) obj_p;


Is this conversion object->extended_object allowed here? Shouldn't there be a check if it is an extended object at all?

galpeter · 2019-02-08T09:43:18Z

jerry-core/ecma/builtin-objects/ecma-builtin-iterator-prototype.c

+ * The %IteratorPrototype% object's '@@iterator' routine
+ *
+ * See also:
+ *          ECMA-262 v6, 22.1.2.1


In the Ecma docs the 22.1.2.1 is for Array.from ( items [ , mapfn [ , thisArg ] ] ). Is this See also entry ok? The reference 25.1.2.1 %IteratorPrototype% [ @@iterator ] ( ) would be better IMHO.

galpeter · 2019-02-08T09:56:23Z

jerry-core/lit/lit-magic-strings.ini

@@ -75,6 +76,7 @@ LIT_MAGIC_STRING_JOIN = "join"
 LIT_MAGIC_STRING_KEYS = "keys"
 LIT_MAGIC_STRING_NAME = "name"
 LIT_MAGIC_STRING_NULL = "null"
+LIT_MAGIC_STRING_NEXT = "next"


Shouldn't the entry next be before the null?

galpeter · 2019-02-08T10:02:06Z

tests/jerry/es2015/array-prototype-entries.js

+array = [0, 1, 2, 3, 4, 5];
+iterator = array.entries ();
+
+for (var i = 0; i < array.length; i++) {


So... this means that if an element is removed from the array the iterator also loses that element, and after the loop the iterator.next().done call will be true?

rerobika force-pushed the array_iterator branch 2 times, most recently from 647241a to ad426b2 Compare December 17, 2018 12:21

rerobika changed the title ~~Implement Array iterators~~ Implement Iterator interface and Array iterators Dec 17, 2018

rerobika force-pushed the array_iterator branch 3 times, most recently from da66b1c to 9b1a982 Compare December 21, 2018 10:07

rerobika force-pushed the array_iterator branch from 9b1a982 to 792b3c7 Compare January 3, 2019 11:12

zherczeg requested changes Jan 9, 2019

View reviewed changes

rerobika force-pushed the array_iterator branch from 792b3c7 to 00591fb Compare January 28, 2019 08:22

rerobika added development Feature implementation ES2015 Related to ES2015 features labels Jan 30, 2019

rerobika force-pushed the array_iterator branch from 00591fb to e203f94 Compare January 31, 2019 10:57

zherczeg approved these changes Jan 31, 2019

View reviewed changes

jerry-core/ecma/base/ecma-gc.c Outdated Show resolved Hide resolved

rerobika force-pushed the array_iterator branch from e203f94 to d7e48c0 Compare January 31, 2019 15:26

rerobika mentioned this pull request Jan 31, 2019

Use custom dispatcher for Array.prototype routines #2742

Merged

zherczeg approved these changes Feb 1, 2019

View reviewed changes

LaszloLango requested changes Feb 8, 2019

View reviewed changes

Implement Iterator interface and Array iterators

e86fc09

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

rerobika force-pushed the array_iterator branch from d7e48c0 to e86fc09 Compare February 8, 2019 09:21

LaszloLango approved these changes Feb 8, 2019

View reviewed changes

rerobika merged commit 4f5ffb4 into jerryscript-project:master Feb 8, 2019

galpeter reviewed Feb 8, 2019

View reviewed changes

rerobika deleted the array_iterator branch February 28, 2019 11:14

		ecma_object_t *array_object_p = ECMA_GET_POINTER (ecma_object_t,
		ext_obj_p->u.pseudo_array.u2.iterated_value_cp);


		ecma_extended_object_t ext_array_obj_p = (ecma_extended_object_t ) array_object_p;

		length = ext_array_obj_p->u.array.length;

Implement Iterator interface and Array iterators #2640

Implement Iterator interface and Array iterators #2640

Uh oh!

Conversation

rerobika commented Dec 12, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zherczeg commented Jan 9, 2019

Uh oh!

zherczeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zherczeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rerobika commented Feb 8, 2019

Uh oh!

LaszloLango left a comment

Choose a reason for hiding this comment

Uh oh!

galpeter Feb 8, 2019

Choose a reason for hiding this comment

Uh oh!

galpeter Feb 8, 2019

Choose a reason for hiding this comment

Uh oh!

galpeter Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

galpeter Feb 8, 2019

Choose a reason for hiding this comment

Uh oh!

galpeter Feb 8, 2019

Choose a reason for hiding this comment

Uh oh!

galpeter Feb 8, 2019

Choose a reason for hiding this comment

Uh oh!

galpeter Feb 8, 2019

Choose a reason for hiding this comment

Uh oh!

galpeter Feb 8, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

galpeter Feb 8, 2019 •

edited

Loading