Fix super keyword parsing for arrow functions #2664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
force-pushed
the
fix_issue_2657
branch
from
5884d5e to
3c30071
Compare
zherczeg
requested changes
Jan 8, 2019
rerobika
force-pushed
the
fix_issue_2657
branch
from
3c30071 to
c754d95
Compare
rerobika
changed the title
|
What happened with the test case? |
LaszloLango
dismissed
their stale review
Dismiss my previous review, because the PR changed too much since then.
rerobika
force-pushed
the
fix_issue_2657
branch
from
c754d95 to
e37b414
Compare
|
@zherczeg I've added the missing test case. |
rerobika
force-pushed
the
fix_issue_2657
branch
from
e37b414 to
e94fd6e
Compare
|
Note: #2686 must land first. |
rerobika
force-pushed
the
fix_issue_2657
branch
from
e94fd6e to
90e54e4
Compare
|
The patch is updated to the latest master after #2686 has landed. |
akosthekiss
reviewed
Jan 19, 2019
akosthekiss
reviewed
Jan 19, 2019
This patch fixes jerryscript-project#2657. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
rerobika
force-pushed
the
fix_issue_2657
branch
from
90e54e4 to
78c18af
Compare
|
@akosthekiss Thanks for the review, I've updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #2657.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]