-
Notifications
You must be signed in to change notification settings - Fork 684
Inner classes should not finalize the parent's class heritage environment #2686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
akosthekiss
merged 1 commit into
jerryscript-project:master
from
rerobika:fix_issue_2667
Jan 16, 2019
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* Copyright JS Foundation and other contributors, http://js.foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| var console = { assert : assert }; | ||
|
|
||
| class C1 { | ||
| f () { | ||
| return 5; | ||
| } | ||
| } | ||
|
|
||
| class C2 extends C1 { | ||
| f () { | ||
| assert (super.f () === 5); | ||
|
|
||
| class G { | ||
| g () { | ||
| assert (super.f === undefined); | ||
| assert (super.toString () === "[object Object]"); | ||
| var a = super.valueOf (); | ||
| try { | ||
| a (); | ||
| assert (false); | ||
| } catch (e) { | ||
| assert (e instanceof TypeError); | ||
| } | ||
| } | ||
|
|
||
| constructor () { | ||
| // Test to overwrite the current lit-object | ||
| console.assert (Object.getPrototypeOf (this) === G.prototype); | ||
|
|
||
| try { | ||
| eval ("super ()"); | ||
| assert (false); | ||
| } catch (e) { | ||
| assert (e instanceof SyntaxError); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| var g = new G (); | ||
| g.g (); | ||
| } | ||
| } | ||
|
|
||
| (new C2).f (); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this change is necessary. Where else is
result_indexused?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be. That was currently an unrevealed bug, since the
parser_parse_functioncan overwrite the literal_object and increase the literal count as well. But thanks for the reminding I'll add a test case for it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I see what I've missed here: is it
parser_parse_functionthat may updatecontext_p->literal_countand that's why it should be saved? If so, it's OK. But I think it would be better not to injectresult_indexin the middle ofliteral_p->fieldassignments. It could be simple moved two lines upwards.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. Okay it can me moved up.