[Proposal] Introduce new jerry-ext methods to ease method/property registration #2715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder whether this proposal could be merged into jerry-ext/handler somehow? That extension module contains oft-used native function implementations and a helper to register them into the global object. Couldn't that be extended with helper(s) to register functions 'elsewhere', too? (Property registration would be a bit of an outlier in jerry-ext/handler, I know. At least the name "handler" doesn't seem to fit perfectly.) |
|
I have no objection to have this function. |
rerobika
reviewed
Feb 22, 2019
galpeter
force-pushed
the
ext-reg-funcs
branch
2 times, most recently
from
0f5daba to
14b8219
Compare
rerobika
requested changes
Apr 1, 2019
galpeter
force-pushed
the
ext-reg-funcs
branch
3 times, most recently
from
bc33cf2 to
2198bdd
Compare
dbatyai
reviewed
Jul 17, 2019
galpeter
force-pushed
the
ext-reg-funcs
branch
2 times, most recently
from
1b5f638 to
c1fc4e8
Compare
New methods
* jerryx_set_properties: Allows multiple property registration for via a single call
* jerryx_set_property_str: Allows property registration without the need to
create the property name JS value. The property name can be directly passed
as a `const char*` value and must be zero terminated.
* jerryx_get_property_str: Allows getting a property value on a given object.
The property name can be directly passed as a `const char*` value.
* jerryx_has_property_str: Allows checking if a property exists on a given object.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New methods
create the property name JS value. The property name can be directly passed
as a
const char*value and must be zero terminated.