-
Notifications
You must be signed in to change notification settings - Fork 684
Added new 'jerry_value_instanceof' API function. #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
LaszloLango
wants to merge
1
commit into
jerryscript-project:master
from
LaszloLango:add-instanceof-api
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
/* Copyright JS Foundation and other contributors, http://js.foundation | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#include "jerryscript.h" | ||
|
||
#include "test-common.h" | ||
|
||
#define T(lhs, rhs, res) \ | ||
{ lhs, rhs, res } | ||
|
||
typedef struct | ||
{ | ||
jerry_value_t lhs; | ||
jerry_value_t rhs; | ||
bool expected; | ||
} test_entry_t; | ||
|
||
static jerry_value_t | ||
my_constructor (const jerry_value_t func_val, /**< function */ | ||
const jerry_value_t this_val, /**< this */ | ||
const jerry_value_t argv[], /**< arguments */ | ||
const jerry_length_t argc) /**< number of arguments */ | ||
{ | ||
(void) func_val; | ||
(void) this_val; | ||
(void) argv; | ||
(void) argc; | ||
return jerry_create_undefined (); | ||
} /* my_constructor */ | ||
|
||
int | ||
main (void) | ||
LaszloLango marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
TEST_INIT (); | ||
|
||
jerry_init (JERRY_INIT_EMPTY); | ||
|
||
jerry_value_t base_obj = jerry_create_object (); | ||
jerry_value_t constructor = jerry_create_external_function (my_constructor); | ||
|
||
jerry_value_t no_proto_instance_val = jerry_construct_object (constructor, NULL, 0); | ||
|
||
jerry_value_t prototype_str = jerry_create_string ((const jerry_char_t *) "prototype"); | ||
jerry_value_t res = jerry_set_property (constructor, prototype_str, base_obj); | ||
jerry_release_value (prototype_str); | ||
TEST_ASSERT (!jerry_value_is_error (res)); | ||
jerry_release_value (res); | ||
|
||
jerry_value_t instance_val = jerry_construct_object (constructor, NULL, 0); | ||
|
||
jerry_value_t error = jerry_create_error_from_value (base_obj, false); | ||
|
||
test_entry_t bool_tests[] = | ||
{ | ||
T (jerry_acquire_value (instance_val), jerry_acquire_value (constructor), true), | ||
T (jerry_acquire_value (no_proto_instance_val), jerry_acquire_value (constructor), false), | ||
T (jerry_acquire_value (base_obj), jerry_acquire_value (constructor), false) | ||
}; | ||
|
||
for (uint32_t idx = 0; idx < sizeof (bool_tests) / sizeof (test_entry_t); idx++) | ||
{ | ||
jerry_value_t result = jerry_instanceof (bool_tests[idx].lhs, bool_tests[idx].rhs); | ||
TEST_ASSERT (!jerry_value_is_error (result)); | ||
TEST_ASSERT (jerry_get_boolean_value (result) == bool_tests[idx].expected); | ||
jerry_release_value (bool_tests[idx].lhs); | ||
jerry_release_value (bool_tests[idx].rhs); | ||
jerry_release_value (result); | ||
} | ||
|
||
test_entry_t error_tests[] = | ||
{ | ||
T (jerry_acquire_value (constructor), jerry_acquire_value (instance_val), true), | ||
T (jerry_create_undefined (), jerry_acquire_value (constructor), true), | ||
T (jerry_acquire_value (instance_val), jerry_create_undefined (), true), | ||
T (jerry_acquire_value (instance_val), jerry_acquire_value (base_obj), true), | ||
T (jerry_acquire_value (error), jerry_acquire_value (constructor), true), | ||
T (jerry_acquire_value (instance_val), jerry_acquire_value (error), true), | ||
T (jerry_create_string ((const jerry_char_t *) ""), jerry_create_string ((const jerry_char_t *) ""), true), | ||
T (jerry_create_string ((const jerry_char_t *) ""), jerry_create_number (5.0), true), | ||
T (jerry_create_number (5.0), jerry_create_string ((const jerry_char_t *) ""), true), | ||
T (jerry_create_array (1), jerry_create_array (1), true), | ||
T (jerry_create_array (1), jerry_create_object (), true), | ||
T (jerry_create_object (), jerry_create_array (1), true), | ||
T (jerry_create_null (), jerry_create_object (), true), | ||
T (jerry_create_object (), jerry_create_string ((const jerry_char_t *) ""), true) | ||
}; | ||
|
||
for (uint32_t idx = 0; idx < sizeof (error_tests) / sizeof (test_entry_t); idx++) | ||
{ | ||
jerry_value_t result = jerry_instanceof (error_tests[idx].lhs, error_tests[idx].rhs); | ||
TEST_ASSERT (jerry_value_is_error (result) == error_tests[idx].expected); | ||
jerry_release_value (error_tests[idx].lhs); | ||
jerry_release_value (error_tests[idx].rhs); | ||
jerry_release_value (result); | ||
} | ||
|
||
jerry_release_value (base_obj); | ||
jerry_release_value (constructor); | ||
jerry_release_value (error); | ||
jerry_release_value (instance_val); | ||
jerry_release_value (no_proto_instance_val); | ||
|
||
jerry_cleanup (); | ||
|
||
return 0; | ||
} /* main */ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there any difference between the es5.1 vs es2015
instanceof
internal workings? Could that affect the api workings?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not affect the api workings, but may affect the internal workings (e.g.: instance of classes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classes are simple functions, the only specializations they have is a bytecode status flag, so I think it couldn't have any affect on it.