Skip to content

Added new 'jerry_binary_operation' API function #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LaszloLango
Copy link
Contributor

JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]

@LaszloLango LaszloLango requested a review from galpeter February 1, 2019 13:02
@LaszloLango LaszloLango added api Related to the public API development Feature implementation labels Feb 1, 2019
@LaszloLango LaszloLango added this to the Release 2.0 milestone Feb 1, 2019
@LaszloLango
Copy link
Contributor Author

@galpeter thanks for the review, I've updated the PR.

Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango
Copy link
Contributor Author

@galpeter thanks for the review, I've updated the PR

JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LaszloLango LaszloLango merged commit 81ccd6a into jerryscript-project:master Feb 6, 2019
@LaszloLango LaszloLango mentioned this pull request Feb 19, 2019
@LaszloLango LaszloLango deleted the add-jerry-binary-op branch March 29, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the public API development Feature implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants