Skip to content

Correctly propagate super prop ref when parsing expressions #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

galpeter
Copy link
Contributor

@galpeter galpeter commented Sep 6, 2019

The "super prop ref" flag is incorrectly used at multiple expressions
as it was only cleared if there was an assignment operation.

The "super prop ref" flag is incorrectly used at multiple expressions
as it was only cleared if there was an assignment operation.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
@galpeter galpeter added bug Undesired behaviour ecma core Related to core ECMA functionality labels Sep 6, 2019
@galpeter
Copy link
Contributor Author

galpeter commented Sep 6, 2019

Fixes: #3067

@galpeter galpeter requested a review from rerobika September 6, 2019 07:55
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour ecma core Related to core ECMA functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants