Fix TypedArray.slice with external array buffer #3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of TypedArrays which were constructed with an ArrayBuffer the `slice` method incorrectly added the `byteOffset` value of when the elements were copied. There is no need to add the `byteOffset` value for the ArrayBuffer's contents pointer as it is already added by the `ecma_typedarray_get_buffer` call. JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of TypedArrays which were constructed with an ArrayBuffer
the
slicemethod incorrectly added thebyteOffsetvalue ofwhen the elements were copied.
There is no need to add the
byteOffsetvalue for the ArrayBuffer'scontents pointer as it is already added by the
ecma_typedarray_get_buffercall.
Fixes: #3078