Skip to content

Fix EXTERNAL_LIBC_INTERFACE check with USE_COMPILER_DEFAULT_LIBC #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2015
Merged

Fix EXTERNAL_LIBC_INTERFACE check with USE_COMPILER_DEFAULT_LIBC #343

merged 1 commit into from
Jul 12, 2015

Conversation

seanshpark
Copy link
Contributor

Related with #331

JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]

@egavrin
Copy link
Contributor

egavrin commented Jul 9, 2015

Cross build fails are not related to the PR.

@egavrin egavrin added the bug Undesired behaviour label Jul 9, 2015
@egavrin
Copy link
Contributor

egavrin commented Jul 9, 2015

Good to me

@ruben-ayrapetyan ruben-ayrapetyan self-assigned this Jul 9, 2015
@galpeter
Copy link
Contributor

galpeter commented Jul 9, 2015

lgtm

@ruben-ayrapetyan
Copy link
Contributor

@seanshpark, could you, please, describe the issue that is fixed by the changes?

@seanshpark
Copy link
Contributor Author

Yes,
What I understood is that, when 'USE_COMPILER_DEFAULT_LIBC' is 'YES' then 'EXTERNAL_LIBC_INTERFACE' should not be defined or if defined, value should be "UNDEFINED". if not, the both is defined by the caller and I think should be treated as conflict.
With IoT.js, building for arm-linux with USE_COMPILER_DEFAULT_LIBC but without EXTERNAL_LIBC_INTERFACE, I get

CMake Error at CMakeLists.txt:98 (message):
  EXTERNAL_LIBC_INTERFACE='' should not be set in case compiler's default
  libc is used (USE_COMPILER_DEFAULT_LIBC=YES)

(line number 98 may not be the same)
So to solve this result is this PR

@ruben-ayrapetyan
Copy link
Contributor

@seanshpark, thank you for detailed explanation of the issue.

@ruben-ayrapetyan
Copy link
Contributor

Looks good to me

@egavrin
Copy link
Contributor

egavrin commented Jul 10, 2015

make push

@seanshpark seanshpark merged commit 13cf314 into jerryscript-project:master Jul 12, 2015
@seanshpark seanshpark deleted the external_libc branch July 12, 2015 23:29
@seanshpark seanshpark mentioned this pull request Jul 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Undesired behaviour
Projects
None yet
Milestone
Maintenance of ECMA functionality
Development

Successfully merging this pull request may close these issues.
4 participants
@seanshpark @egavrin @galpeter @ruben-ayrapetyan