External build fix for not linux platforms #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@egavrin , Jenkins reports with What can I do? |
| @@ -256,6 +266,9 @@ project (Jerry CXX C ASM) | |||
| # stm32f4 | |||
| set(SOURCE_JERRY_STANDALONE_MAIN_MCU_STM32F4 main-mcu.cpp) | |||
|
|
|||
| # EXTERNAL dummy | |||
| set(SOURCE_JERRY_STANDALONE_MAIN_EXTERNAL main-external.cpp) | |||
There was a problem hiding this comment.
@seanshpark, maybe we shouldn't add the file, as external application provides its own main. So, jerryscript, in the case, is just linked to some another application.
seanshpark
force-pushed
the
external_build
branch
from
fa22750 to
65f9fba
Compare
|
@ruben-ayrapetyan , thank you for your help. this PR is for both #342 and #344 |
seanshpark
force-pushed
the
external_build
branch
from
65f9fba to
703828e
Compare
|
Looks good to me. |
|
@seanshpark please change Signed-off order for "External build fix", otherwise precommit will fail: |
seanshpark
force-pushed
the
external_build
branch
2 times, most recently
from
f6db046 to
7ae53d6
Compare
|
lgtm |
Added generic build for none linux platforms, as nuttx has be removed by jerryscript-project#330 JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected] JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
to solve jerryscript-project#342 JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected] JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
seanshpark
force-pushed
the
external_build
branch
from
7ae53d6 to
bc0ca7b
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added generic build for not linux(embedded) platforms as nuttx has be removed by #330
JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]