Minor fix in for-of statement parsing #4814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ossy-szeged
reviewed
Nov 2, 2021
|
Test suggestion: |
robertsipka
force-pushed
the
minor_fix_forof
branch
from
52a3033 to
26cc272
Compare
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]
robertsipka
force-pushed
the
minor_fix_forof
branch
from
26cc272 to
715f7e8
Compare
|
Ohh, yes, I've forgotten to add a test case, thanks for your suggestions, I've updated it accordingly. |
zherczeg
approved these changes
Nov 2, 2021
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| for (a of [1] || [2]) {} |
There was a problem hiding this comment.
I am not sure a new test is needed, we can add this to the for-of test. But it does not hurt eaither, so it is up to you.
rerobika
approved these changes
Nov 2, 2021
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| for (a of [1] || [2]) {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.