Skip to content

Update NuttX target to releases/10.2 #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2021
Merged

Update NuttX target to releases/10.2 #4822

merged 1 commit into from
Nov 23, 2021

Conversation

rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Nov 12, 2021

  • Updated NuttX from releases/9.0 to releases/10.2
    • Modified Makefile according to NuttX changes
  • Updated README.md file
    • Added ROM File System and memory card usage descriptions as possible ways to share JavaScript input files with the device

@rtakacs rtakacs force-pushed the nuttx-update branch 4 times, most recently from 4199a2c to e33cb4c Compare November 15, 2021 11:56
robertsipka
robertsipka approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tried it, works like a charm.
Minor suggestions: More dependencies are already needed for the toolchain and the kconfig generator, so I would move up the following description:
https://github.com/apache/incubator-nuttx/blob/releases/10.2/Documentation/quickstart/install.rst
stlink also has dependencies that are worth mentioning to install:
gtk+-3.0 libusb-1.0-0-dev minicom

@rtakacs rtakacs force-pushed the nuttx-update branch 3 times, most recently from ced979b to 31ad5a4 Compare November 17, 2021 15:02
@rtakacs
Copy link
Contributor Author

rtakacs commented Nov 17, 2021 •
edited
Loading

@robertsipka I've added an install-deps.sh file that contains all the packages that are required by projects (NuttX, STLink) and serial communication. Packages are copied from https://github.com/apache/incubator-nuttx/blob/releases/10.2/Documentation/quickstart/install.rst file.

@robertsipka
Copy link
Contributor

even better, still looks good to me.

@rtakacs rtakacs force-pushed the nuttx-update branch 4 times, most recently from 217dfd5 to 4aa9913 Compare November 19, 2021 10:41
@rtakacs
Update NuttX target to releases/10.2
55ba0eb 
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs [email protected]
@rtakacs
Copy link
Contributor Author

rtakacs commented Nov 19, 2021

@robertsipka FYI, I've extended the Makefile with JerryScript compilation. In this case, NuttX automatically builds JerryScript as its dependency. (And that is not a different step for the user.)

@dbatyai dbatyai merged commit 3737a28 into jerryscript-project:master Nov 23, 2021
@rtakacs rtakacs deleted the nuttx-update branch November 23, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsipka robertsipka robertsipka approved these changes

@dbatyai dbatyai dbatyai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtakacs @robertsipka @dbatyai