-
Notifications
You must be signed in to change notification settings - Fork 684
Implement String.prototype.lastIndexOf() #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
lvidacs
wants to merge
1
commit into
jerryscript-project:master
from
lvidacs:string-prototype-lastindexof
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| // Copyright 2015 Samsung Electronics Co., Ltd. | ||
| // Copyright 2015 University of Szeged. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // check properties | ||
| assert(Object.getOwnPropertyDescriptor(String.prototype.lastIndexOf, 'length').configurable === false); | ||
|
|
||
| assert(Object.getOwnPropertyDescriptor(String.prototype.lastIndexOf, 'length').enumerable === false); | ||
|
|
||
| assert(Object.getOwnPropertyDescriptor(String.prototype.lastIndexOf, 'length').writable === false); | ||
|
|
||
| assert(String.prototype.lastIndexOf.length === 1); | ||
|
|
||
| // simple checks | ||
| assert("Hello welcome, welcome to the universe.".lastIndexOf("welcome") === 15); | ||
|
|
||
| assert("Hello world, welcome to the universe.".lastIndexOf("Hello world, welcome to the universe.") === 0); | ||
|
|
||
| assert("Hello welcome, welcome to the universe.".lastIndexOf("welcome", 5) === -1); | ||
|
|
||
| assert("Hello welcome, welcome to the universe.".lastIndexOf("welcome", -100) == -1); | ||
|
|
||
| assert("Hello welcome, welcome to the universe.".lastIndexOf("welcome", 15) === 15); | ||
|
|
||
| assert("Hello welcome, welcome to the universe o.".lastIndexOf("o", 10) === 10); | ||
|
|
||
| assert("Hello welcome, welcome to the universe o.".lastIndexOf("o", 25) === 24); | ||
|
|
||
| assert("Helloooo woooorld".lastIndexOf("oooo", 6) === 4); | ||
|
|
||
| // check empty string | ||
| assert(String.prototype.lastIndexOf.call(new String()) === -1); | ||
|
|
||
| assert(String.prototype.lastIndexOf.call("Hello world, welcome to the universe.","") === 37); | ||
|
|
||
| assert(String.prototype.lastIndexOf.call("","") === 0); | ||
|
|
||
| // check NaN | ||
| assert("Hello world, welcome to the universe.".lastIndexOf(NaN) === -1); | ||
|
|
||
| assert("Hello world, welcome to the universe.".lastIndexOf("o", NaN) === 22); | ||
|
|
||
| // check Object | ||
| assert(String.prototype.lastIndexOf.call({}) === -1); | ||
|
|
||
| // check +-Inf | ||
| assert("hello world!".lastIndexOf("world", -Infinity) === -1); | ||
|
|
||
| assert("hello world!".lastIndexOf("world", Infinity) === 6); | ||
|
|
||
| // check numbers | ||
| assert("hello world!".lastIndexOf(-1) === -1); | ||
|
|
||
| assert("hello 0 world!".lastIndexOf(-0) === 6); | ||
|
|
||
| // check undefined | ||
| assert("hello world!".lastIndexOf(undefined) === -1); | ||
|
|
||
| var undefined_var; | ||
| assert("Hello world, welcome to the universe.".lastIndexOf("welcome", undefined_var) === 13); | ||
|
|
||
| // check booleans | ||
| assert("true".lastIndexOf(true, false) === 0); | ||
|
|
||
| // check coercible - undefined | ||
| try { | ||
| assert(String.prototype.lastIndexOf.call(undefined) === -1); | ||
| assert(false); | ||
| } catch(e) { | ||
| assert(e instanceof TypeError); | ||
| } | ||
|
|
||
| // check coercible - null | ||
| try { | ||
| assert(String.prototype.lastIndexOf.call(null, 0) === -1); | ||
| assert(false); | ||
| } catch (e) { | ||
| assert(e instanceof TypeError); | ||
| } | ||
|
|
||
| // check coercible - Boolean | ||
| assert(String.prototype.lastIndexOf.call(true, "e") === 3); | ||
| assert(String.prototype.lastIndexOf.call(false, "e") === 4); | ||
|
|
||
| // check coercible - Object | ||
| var test_object = {firstName:"John", lastName:"Doe"}; | ||
| assert(String.prototype.lastIndexOf.call(test_object, "Obj") === 8); | ||
|
|
||
| // check coercible - Number | ||
| assert(String.prototype.lastIndexOf.call(123, "2") === 1); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This argument modifies the behavior a bit so we need to update the function comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first time this appeared as problem? I think charCodeAt also depends on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
charCodeAt needs similar checks, but is a bit simpler and does not use the helper function.