Skip to content

Use ToNumber when checking lastIndex during RegExp exec() #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2015
Merged

Use ToNumber when checking lastIndex during RegExp exec() #493

merged 1 commit into from
Jul 30, 2015

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented Jul 29, 2015

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]

@dbatyai dbatyai added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Jul 29, 2015
@dbatyai dbatyai added this to the ECMA builtins milestone Jul 29, 2015
@kkristof
Copy link
Contributor

Looks good to me.

@egavrin
Copy link
Contributor

egavrin commented Jul 30, 2015

Good to me

@dbatyai dbatyai force-pushed the regexp_lastindex_tonumber branch from abee059 to 297bab9 Compare July 30, 2015 10:48
@dbatyai
Use ToNumber when checking lastIndex during RegExp exec()
fe475ea 
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]
@dbatyai dbatyai force-pushed the regexp_lastindex_tonumber branch from 297bab9 to fe475ea Compare July 30, 2015 11:03
@dbatyai dbatyai merged commit fe475ea into jerryscript-project:master Jul 30, 2015
@dbatyai dbatyai deleted the regexp_lastindex_tonumber branch July 31, 2015 10:58
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
@marckwei marckwei mentioned this pull request Apr 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dbatyai dbatyai

Labels
bug Undesired behaviour ecma builtins Related to ECMA built-in routines
Projects
None yet
Milestone
ECMA builtins
Development

Successfully merging this pull request may close these issues.
3 participants
@dbatyai @kkristof @egavrin