Add option to enable all-in-one build mode #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,8 +121,11 @@ project (JerryCore CXX C ASM) | |||
| set(INCLUDE_THIRD_PARTY_VALGRIND ${CMAKE_SOURCE_DIR}/third-party/valgrind) | |||
|
|
|||
| # Sources | |||
| # All-in-one build | |||
| if("${ENABLE_ALL_IN_ONE}" STREQUAL "ON") | |||
| set(SOURCE_CORE jerry-all-in.cpp) | |||
There was a problem hiding this comment.
This would require to manually update contents of jerry-all-in.cpp upon adding / removing / renaming a module.
It would be better, if the file would be created automatically during build and if it would be placed in cmake's build directory instead of repository's root.
egavrin
added
enhancement
bzsolt
force-pushed
the
all-in-one_build
branch
from
ca835ad to
f150e41
Compare
|
Looks good to me |
|
LGTM |
added 2 commits
November 25, 2015 14:01
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
Related issue: jerryscript-project#626 JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
bzsolt
force-pushed
the
all-in-one_build
branch
from
f150e41 to
fe15730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.