Fix 'Segmentation fault on String.Replace' #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
bug
| ssize_t sz = ecma_string_to_utf8_string (input_string_p, input_buffer_p, (ssize_t) input_string_size); | ||
| JERRY_ASSERT (sz >= 0); | ||
|
|
||
| lit_utf8_byte_t *input_curr_p = input_buffer_p; | ||
| re_ctx.input_start_p = input_buffer_p; |
There was a problem hiding this comment.
if I'd like to be picky -- which I'm obviously not :) -- then I'd suggest moving this in the else branch of if (!input_string_size).
There was a problem hiding this comment.
obviously :) It would look better, so I'll do it. :)
LaszloLango
force-pushed
the
fix-regression-747
branch
from
6696128 to
1e9ecf3
Compare
|
@akiss77, I've updeted the patch. Please check. |
|
LGTM (informally) |
|
LGTM |
Related issue: jerryscript-project#747 JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
LaszloLango
force-pushed
the
fix-regression-747
branch
from
1e9ecf3 to
6b8332e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #747
JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]