Skip to content

Remove jerry_port_ functions from test-common.h #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Remove jerry_port_ functions from test-common.h #880

wants to merge 0 commits into from

Conversation

akosthekiss
Copy link
Member

They are identical to the functions with the same name in
jerry-port.cpp and cause duplicate symbol link errors on OS X.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

@akosthekiss akosthekiss added bug Undesired behaviour minor labels Feb 13, 2016
@akosthekiss
Copy link
Member Author

BTW, the link error messages are:

duplicate symbol _jerry_port_logmsg in:
    CMakeFiles/unit-test-api.dir/tests/unit/test-api.cpp.o
    jerry-core/libunittests.jerry-core.a(jerry-all-in.cpp.o)
duplicate symbol _jerry_port_errormsg in:
    CMakeFiles/unit-test-api.dir/tests/unit/test-api.cpp.o
    jerry-core/libunittests.jerry-core.a(jerry-all-in.cpp.o)
duplicate symbol _jerry_port_putchar in:
    CMakeFiles/unit-test-api.dir/tests/unit/test-api.cpp.o
    jerry-core/libunittests.jerry-core.a(jerry-all-in.cpp.o)
ld: 3 duplicate symbols for architecture x86_64

@seanshpark
Copy link
Contributor

+1

@akosthekiss akosthekiss force-pushed the unittest-jerry-port-dup-removal branch 2 times, most recently from 4925e48 to f761459 Compare February 15, 2016 17:44
@LaszloLango
Copy link
Contributor

LGTM

@akosthekiss akosthekiss force-pushed the unittest-jerry-port-dup-removal branch from f761459 to 7dc0658 Compare February 16, 2016 09:56
@akosthekiss
Copy link
Member Author

Merged in 7dc0658

@akosthekiss akosthekiss deleted the unittest-jerry-port-dup-removal branch February 16, 2016 09:57
@zherczeg zherczeg mentioned this pull request Apr 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akosthekiss akosthekiss

Labels
bug Undesired behaviour minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akosthekiss @seanshpark @LaszloLango