Skip to content

Fix precommit scripts on OSX #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

franc0is
Copy link
Contributor

JerryScript-DCO-1.0-Signed-off-by: François Baldassari [email protected]

@franc0is franc0is force-pushed the fix-precommit-osx branch from 2ac9bf4 to 6f2b200 Compare March 18, 2016 00:32
@LaszloLango
Copy link
Contributor

LGTM

@LaszloLango LaszloLango added bug Undesired behaviour tools Related to the tooling scripts labels Mar 18, 2016
if [[ "$OSTYPE" == "linux"* ]]; then
CPPCHECK_JOBS=${CPPCHECK_JOBS:=$(nproc)}
elif [[ "$OSTYPE" == "darwin"* ]]; then
CPPCHECK_JOBS=${CPPCHECK_JOBS:=$(sysctl -n hw.ncpu)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this work on OSX! This script becomes just a little bit incomplete, however. Please, add a final else branch that sets CPPCHECK_JOBS to something basic default, just to make sure that the script doesn't break. (E.g., if someone builds on freebsd, or whatever.) I'd go for a default of 1.

@zherczeg
Copy link
Member

LGTM

@zherczeg
Copy link
Member

(After the else fix).

JerryScript-DCO-1.0-Signed-off-by: François Baldassari [email protected]
@franc0is franc0is force-pushed the fix-precommit-osx branch from 6f2b200 to b59af40 Compare March 18, 2016 17:06
@franc0is
Copy link
Contributor Author

Added the else clause and rebased on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour tools Related to the tooling scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants