This repository was archived by the owner on Feb 11, 2021. It is now read-only.
Handle FF Ubuntu deviation for mouseup #243
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles #242.
Not sure if you'd rather want to wait for a response from FF. I believe this PR should not break the current behaviour (incl. chorded button presses), while fixing the situation for Ubuntu FF.
button
says which button triggers themouseup
buttons
says which buttons (in summation) are usedCases:
buttons
includes the lifted button's value:buttons === BUTTON_TO_BUTTONS[button]
:buttons !== BUTTON_TO_BUTTONS[button]
:buttons
does not include the lifted button's value:buttons === BUTTON_TO_BUTTONS[button]
:buttons
. Every possible value ofbuttons
uniquely identifies one specific state (bitmap). Thus no other combination of buttons can cause thebuttons
value.buttons !== BUTTON_TO_BUTTONS[button]
:I hope these cases are sound.