Support for temporary items

[davincho]

Behaviour of inject, filter and isNew implemented as proposed in ticket #197

There are still some open points such as DSSave and DSCreate. @jmdobry maybe you can make some comments if I am on the right track.

[jmdobry]

I'm not sure I like the performance implications of storing an array of temporary IDs, and having to search the array on every iteration of the filter callback. What about actually attaching a property to a temporary item itself that marks it as temporary? Or instead of an array of IDs, keep an index of IDs for O(1) lookup times?

[davincho]

Yes that make sense. I was thinking about a property for each instance but I did not want to mix data properties and internal properties of an instance. Maybe I missed something - is there a way of hiding an internal property?

[davincho]

@jmdobry I am thinking about what would be the best way of replacing the artifical ID with the one returned by the server. Foreign keys of other items referencing the temporary item have to be updated as well.

[jmdobry]

I hadn't considered that, I think I'm losing enthusiasm for this feature.

[davincho]

Mh too bad - I think this feature could be really helpful. I thought about if it would be possible keeping the original ID (=guid) internally, while exposing the updated Id to the user. Or do you prefer to abandon the feature completely?

[jmdobry]

I'm working on this in v3, I'll see if I can find a nice way to back port it.

[jessehouchins]

@jmdobry Am i right in thinking that this only handles temporary ids for a specific resource and DOES NOT update relations when the new id is returned from the server?

[jmdobry]

Right

On Mon, Feb 29, 2016, 5:05 PM Jesse Houchins [email protected]
wrote:

@jmdobry https://github.com/jmdobry Am i right in thinking that this
only handles temporary ids for a specific resource and DOES NOT update
relations when the new id is returned from the server?

—
Reply to this email directly or view it on GitHub
#284 (comment).

[rgant]

Is there any documentation for this feature?

Throughout my code when creating new resources I've had to do things like:

var newStrategy = DS.createInstance('report_strategies', {reportid: theReport.id, id: ''});

But maybe I should have been doing:

var newStrategy = DS.createInstance('report_strategies', {reportid: theReport.id}, {temporary: true});

I don't see the word "temporary" anywhere when searching the documentation.

[rgant]

Seems like that won't work because resolveId doesn't know about the temporary option and many of promises check for the id being a string or number and reject immediately if not. So I guess this doesn't really help.

I'm not finding the documentation I need to understand the whole process of how to create new resources in the real world.

[jmdobry]

In V3 records have an isNew() method, which just returns true or false based on whether the record has a primary key. Records with and without primary keys can be inserted into Collections. Records without primary keys are invisible to certain operations, like Collection#get(id). Collections also have a helper method for retrieving unsaved records from the collection (since they don't have IDs): Collection#unsaved()