Field IDs Patch #496
Closed
Field IDs Patch #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like tests fail because input names have changed |
|
Sounds great @davidlgj! Thanks, looking forward to it :) |
plong0
force-pushed
the
patch/field-ids
branch
from
07e081a to
89f4ac8
Compare
|
made new PR #560 off development branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates name and ids (along with corresponding label for="..." attributes) to use the full key (hyphen-delimited) rather than only the last piece.
If a parent FormController is found, we prepend the form's name onto the id values.
We also append the hyphen-delimited key to form.htmlClass, allowing styling of specific fields without having to manually set an htmlClass for each field.