Skip to content

Fix Karma Unit Tests (support/0.x) #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2018
Merged

Fix Karma Unit Tests (support/0.x) #979

merged 2 commits into from
Jul 7, 2018

Conversation

rthaut
Copy link
Contributor

@rthaut rthaut commented Jul 7, 2018

Description

This PR fixes the Karma unit tests for the support/0.x branch. Specifically, the checks for the has-error and has-success classes were targeting the wrong DOM nodes.

Checklist

  • I have read and understand the CONTRIBUTIONS.md file
  • I have searched for and linked related issues
  • I have created test cases to ensure quick resolution of the PR is easier
  • I am NOT targeting main branch
  • I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

@Anthropic Anthropic merged commit ba3e5f8 into json-schema-form:support/0.x Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rthaut @Anthropic