Getting exception from deleteNamespacedStatefulSet() call

[chlung]

Hi,

I was getting exception when I issued deleteNamespacedStatefulSet() call. The call did delete statefulset, but it throw the exception back to caller.

Exception:
java.lang.IllegalStateException: Expected a string but was BEGIN_OBJECT at line 1 column 2004 path $.status

Here is my code,
V1DeleteOptions deleteOptions = new V1DeleteOptions()
Boolean orphanDependents = true

apiInstance.deleteNamespacedStatefulSet(name, namespace, deleteOptions, null, 60, orphanDependents, null)

Thanks.

[brendandburns]

I'll investigate this, I suspect that it is a problem with the Swagger/OpenAPI spec indicating the wrong code for Delete...

But we'll need to investigate to be sure.

[chlung]

@brendanburns thanks.

[brendandburns]

Ok, I figured out the issue here...

When you delete a StatefulSet (and probably a ReplicaSet too) it initially returns a StatefulSet object, but eventually it returns a Status object.

This means that the Swagger should be oneOf(StatefulSet, Status)

But the Kubernetes Swagger here:

https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json

Only has the Status object.

Thus, the generated Java code barfs when it tries to parse a StatefulSet object into a Status object.

Unfortunately go-restful when generates the swagger spec doesn't support oneOf as far as I know, thus we're going to either need to massage the swagger spec before client generation, improve go-restful's swagger generation or switch to a different way of generating swagger...

None of these are great options, and none of them will happen very quickly. So for now, I think the best you can do is catch this Exception and move on...

Sorry!

@mbohlool @lwander @lavalamp fyi

[chlung]

@brendandburns ok. I can handle it in my code. Thanks for debugging this issue. Should we keep this issue for tracking purpose or close it for now?

[brendandburns]

Yes, let's definitely keep this open.

[mbohlool]

`oneof` is not supported in OpeAPI v2. It is possible to fix generator when we move to OpenAPI v3 (both our kube-openapi and swagger-codegen should support it).

…

On Oct 8, 2017 6:47 AM, "Brendan Burns" ***@***.***> wrote: Yes, let's definitely keep this open. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#86 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABic4ONQvsUMsx4rLtWydW2eSPyywU6Rks5sqNJrgaJpZM4Pt_sW> .

[neuromantik33]

Bug also exists when trying to delete a namespaced Job. JSON output is here

{
  "kind": "Job",
  "apiVersion": "batch/v1",
  "metadata": {
    "name": "pi-s44bw",
    "generateName": "pi-",
    "namespace": "default",
    "selfLink": "/apis/batch/v1/namespaces/default/jobs/pi-s44bw",
    "uid": "a48d258d-faea-11e7-bdc1-42010a84018c",
    "resourceVersion": "11082999",
    "creationTimestamp": "2018-01-16T18:25:34Z",
    "deletionTimestamp": "2018-01-16T18:25:55Z",
    "deletionGracePeriodSeconds": 0,
    "labels": {
      "controller-uid": "a48d258d-faea-11e7-bdc1-42010a84018c",
      "job-name": "pi-s44bw"
    },
    "finalizers": [
      "orphan"
    ]
  },
  "spec": {
    "parallelism": 1,
    "completions": 1,
    "backoffLimit": 4,
    "selector": {
      "matchLabels": {
        "controller-uid": "a48d258d-faea-11e7-bdc1-42010a84018c"
      }
    },
    "template": {
      "metadata": {
        "creationTimestamp": null,
        "labels": {
          "controller-uid": "a48d258d-faea-11e7-bdc1-42010a84018c",
          "job-name": "pi-s44bw"
        }
      },
      "spec": {
        "containers": [
          {
            "name": "perl",
            "image": "perl",
            "command": [
              "perl",
              "-Mbignum=bpi",
              "-wle",
              "print bpi(2000)"
            ],
            "resources": {},
            "terminationMessagePath": "/dev/termination-log",
            "terminationMessagePolicy": "File",
            "imagePullPolicy": "Always"
          }
        ],
        "restartPolicy": "Never",
        "terminationGracePeriodSeconds": 30,
        "dnsPolicy": "ClusterFirst",
        "securityContext": {},
        "schedulerName": "default-scheduler"
      }
    }
  },
  "status": {
    "conditions": [
      {
        "type": "Complete",
        "status": "True",
        "lastProbeTime": "2018-01-16T18:25:41Z",
        "lastTransitionTime": "2018-01-16T18:25:41Z"
      }
    ],
    "startTime": "2018-01-16T18:25:34Z",
    "completionTime": "2018-01-16T18:25:41Z",
    "succeeded": 1
  }
}

However API says status is a string...

com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected a string but was BEGIN_OBJECT at line 1 column 1152 path $.status

	at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:220)
	at com.google.gson.Gson.fromJson(Gson.java:879)
	at com.google.gson.Gson.fromJson(Gson.java:844)
	at com.google.gson.Gson.fromJson(Gson.java:793)
	at io.kubernetes.client.JSON.deserialize(JSON.java:106)
	at io.kubernetes.client.ApiClient.deserialize(ApiClient.java:668)
	at io.kubernetes.client.ApiClient.handleResponse(ApiClient.java:871)
	at io.kubernetes.client.ApiClient.execute(ApiClient.java:798)
	at io.kubernetes.client.apis.BatchV1Api.deleteNamespacedJobWithHttpInfo(BatchV1Api.java:511)
	at io.kubernetes.client.apis.BatchV1Api.deleteNamespacedJob(BatchV1Api.java:491)
	at com.oscaro.kubernetes.ApiHelper._clinit__closure5$_closure7(ApiHelper.groovy:80)
	at com.oscaro.kubernetes.ApiHelper._clinit__closure5(ApiHelper.groovy:73)
	at com.oscaro.kubernetes.JobExecutorTest.it should return the expected output from the job "#ns/#prefix-*"(JobExecutorTest.groovy:53)
Caused by: java.lang.IllegalStateException: Expected a string but was BEGIN_OBJECT at line 1 column 1152 path $.status
	at com.google.gson.stream.JsonReader.nextString(JsonReader.java:831)
	at com.google.gson.internal.bind.TypeAdapters$16.read(TypeAdapters.java:422)
	at com.google.gson.internal.bind.TypeAdapters$16.read(TypeAdapters.java:410)
	at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:116)
	at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:216)
	... 12 more

[brendandburns]

Yeah, this is may apply to all object deletes, we could try to wrap if we really wanted to...

[rjeberhard]

Since we're using the async API variants, there isn't a good way to wrap this in our code. So, depending on how far away the OpenAPI v3 fix is I'd be grateful if this was wrapped -- at least so that it doesn't gum up the logs.