Skip to content

Add typing to HasFactory the Laravel way #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mondesirm
Copy link
Contributor

Hi, looks like I was beat to it regarding this commit.

Context: I'm currently working on a project that uses Laravel's React Starter Kit and I found myself having to customize some stubs and generators more than I thought I would.

Like your last commit and this one, I will create some pull requests that aligns more with Laravel's new starter kits and the way php artisan make:model creates files.

@mondesirm
Copy link
Contributor Author

When I cloned the repo and ran pint, it told me that 101 files had the wrong "line_ending" and when I checked them, they were all using CRLF and now use LF. Is it normal?

I had to revert the changes and just focus on my pull request or else I'd have a messy commit.

@jasonmccreary
Copy link
Collaborator

Closing this for now. Devs can update the stubs if they want them customized. If you really believe this should be core, then I'd rather see it added when the docblock config option is set.

@mondesirm
Copy link
Contributor Author

It's a minor change but I just wanted to imitate the latest versions of Laravel which now includes this for Intellisense.

Thanks for mentioning the docblock config option, I didn't notice it and I should have taken that into account. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants