Skip to content

Update markdown tables #9778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Update markdown tables #9778

merged 5 commits into from
Jul 18, 2024

Conversation

TENIOS
Copy link
Contributor

@TENIOS TENIOS commented Jul 18, 2024

I "freshened up" the tables and fixed some, such as those that were too long and indented (contracts.md). Many tables have become more readable for documentation developers.

Please don't close the PR, I'm willing to fix or put some changes back in. I've done a lot of work and I don't want it to just disappear.

@TENIOS TENIOS marked this pull request as ready for review July 18, 2024 17:58
@taylorotwell
Copy link
Member

I need before and after screenshots of the changes.

@taylorotwell taylorotwell marked this pull request as draft July 18, 2024 18:08
@TENIOS
Copy link
Contributor Author

TENIOS commented Jul 18, 2024

I need before and after screenshots of the changes.

What does it look like on the website?

@TENIOS
Copy link
Contributor Author

TENIOS commented Jul 18, 2024

I took screenshots of only those tables that have changed on the site. Those that have no changes, I did not take a screenshot because they contain changes only in Markdown.

Contracts

Before After
contracts-before{: width="50%"} contracts-after{: width="50%"}

Facades

Before After
facades-before{: width="50%"} facades-after{: width="50%"}

Logging

Before After
logging-before{: width="50%"} logging-after{: width="50%"}

Mail

Before After
mail-before{: width="50%"} mail-after{: width="50%"}

Migrations

Before After
migrations-before{: width="50%"} migrations-after{: width="50%"}

Notifications

Before After
notifications-before{: width="50%"} notifications-after{: width="50%"}

Scheduling

Before After
scheduling-before{: width="50%"} scheduling-after{: width="50%"}

Well. That was a long time coming.

(I know that {: width=“50%”} has no effect, but without them the right photo is always smaller.)

@TENIOS TENIOS marked this pull request as ready for review July 18, 2024 19:44
@TENIOS
Copy link
Contributor Author

TENIOS commented Jul 18, 2024

If you open each screenshot, you'll notice that dots have appeared at the end of sentences where they weren't, and also the unnecessary semicolon in Contracts after Illuminate\Contracts\Pipeline\Pipeline has been removed.

@TENIOS
Copy link
Contributor Author

TENIOS commented Jul 18, 2024

You can make sure that all tables are displayed correctly by use command in cloned laravel.com repository:

git clone --single-branch --branch "update-tables" https://github.com/TENIOS/docs "resources/docs/11.x"

@TENIOS
Copy link
Contributor Author

TENIOS commented Jul 18, 2024

I also noticed that some tables are missing div with class overflow-auto because of what on mobile devices the page is displayed incorrectly.

It's not due to my changes you can check it out at Contracts page in production.

@taylorotwell taylorotwell merged commit 87c1dc3 into laravel:11.x Jul 18, 2024
@TENIOS
Copy link
Contributor Author

TENIOS commented Jul 18, 2024

@taylorotwell, thanks.

@TENIOS TENIOS deleted the update-tables branch July 18, 2024 20:50
@TENIOS TENIOS mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants