Possible [BUG] Can't app::bind a class that extends Eloquent

[johnnncodes]

I can't app::bind() this - class ArrayUserRepository extends Eloquent implements UserRepository { }

But if I'm doing class ArrayUserRepository extends SomeClass implements UserRepository {} it works.

Here is the binding - App::bind('UserRepository', 'ArrayUserRepository');

This is the error - BindingResolutionException: Unresolvable dependency resolving [Parameter #0 [ array $attributes = Array ]].

In the screencast of #L4 about IOC container, it binds the ArrayUserRepository in the UserRepository interface however it is not using Eloquent. I wanted to use eloquent methods so I want ArrayUserRepository to extend Eloquent but it always throws an error when binding it to the UserRepository interface.

Maybe this is a bug?

[franzliedke]

Update your repository. This should be fixed with #80.

[johnnncodes]

@franzliedke - Thanks mate. Will try to update my repo. I updated my repo yesterday but can see the fix is implemented about just 8 hours ago. Will report here if it will now work.

[JoostK]

If it does work, please also stop doing it this way. Consider an instance of Eloquent to be just one row in your database, so an instance of it is certainly not meant to query the database in any way. Just create a separate class which interacts with your Eloquent models.

[johnnncodes]

@JoostK - Hi, thanks for your suggestion but I'm confused. Can you explain it a little bit further or give me a sample?

Do you mean instead of extending Eloquent in the ArrayUserRepository class I should just do:

class ArrayUserRepository implements UserRepository {
public function all()
{
return User::all();
}
}

class User extends Eloquent {
protected $table = 'users';
}

interface UserRepository {
public function all();
}

App::bind('UserRepository', 'ArrayUserRepository');

Am I right? Thanks again in advance.

[franzliedke]

Yes, that's the best practice, because it means your controller, which uses the UserRepository, can function independently from Eloquent - very helpful if you decide to move your data storage to some other system later on.

[johnnncodes]

@franzliedke - I'm now really confused. Since what I want to do is just the same with my sample above. This is what I wanted:

class ArrayUserRepository extends Eloquent implements UserRepository {

protected $table = 'users';

public function all()
{
return self::all();
}
}

interface UserRepository {
public function all();
}

App::bind('UserRepository', 'ArrayUserRepository');

As you can see they are just the same but it is much shorter since I don't need to create a User class that will extend Eloquent. Also I can still easily swap ArrayUserRepository with OtherUserRepository for example then just change the binding to App::bind('UserRepository', 'MongoUserRepository');

Will that be a bad idea? Please explain to me if I'm missing something. thanks.

[johnnncodes]

Updated my repo. Works fine now. Thanks! Anyway please reply to my question above ^ . Thanks!

[franzliedke]

Well, you're not really extending the model class, are you? Thus, you shouldn't. :)

Also, if you really implement your own class, you won't be tempted to use other Eloquent model methods - especially since you should stick to the UserRepository interface.

[johnnncodes]

I thought it was a good idea since the default User model that comes with L4 is like this:

class User extends Eloquent implements UserInterface {}

So based on your answer, if I understand it correctly, just to confirm,

THIS ONE IS BETTER:

class ArrayUserRepository implements UserRepository {
public function all()
{
return User::all();
}
}

class User extends Eloquent {
protected $table = 'users';
}

interface UserRepository {
public function all();
}

App::bind('UserRepository', 'ArrayUserRepository');

---

THAN:

class ArrayUserRepository extends Eloquent implements UserRepository {

protected $table = 'users';

public function all()
{
return self::all();
}
}

interface UserRepository {
public function all();
}

App::bind('UserRepository', 'ArrayUserRepository');

---

Right?

[franzliedke]

Yep. I hope somebody can comment on my reasoning above, but I'm fairly positive. :)

Also, that UserInterface which is implemented by the standard User class has to do with the authentication module, I believe.

[johnnncodes]

@franzliedke - okay. thank you very much for your time :)

@JoostK - thanks thanks thanks! :)

[johnnncodes]

BTW, this issue is now solved after I updated my L4 repo.

CLOSED.