[6.x] Don't copy query parameters to Request.request #36708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't make such a breaking change. |
taylorotwell
pushed a commit
that referenced
this pull request
Aug 9, 2021
…quired (#37921) * Manually populate POST request body with JSON data only when required This fixes a 6 year old bug introduced in #7026 where GET requests would have GET data populated in the POST body property leading to issues around Request::post() and $request->getParsedBody() returning GET values when called on GET requests. This is a resubmit of #17087 & #36708, and fixes #22805. Credit to @dan-har for the initial solution and @mixlion for updating it for >=6.x. The original PR was meant to support POST requests where their Content-type was set to application/json (instead of the typical application/x-www-form-urlencoded), but it introduced a subtle and dangerous bug because while $request->getInputSource() does return the JSON data for JSON requests, it also returns the GET data for GET requests. This commit solves the underlying issue without breaking compatibility with the original functionality. * Add test for non-JSON GET requests * Style fixes * Extra space removal * GitHub's editor needs some work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating a
Requestfrom the baseSymfonyRequest, its query (GET) parameters are copied to therequestfield, but it shouldn't as the field's documentation clearly says it contains only body (POST) parameters:Due to this bug, PSR request created in
RoutingServiceProviderviaPsrHttpFactoryreturns query parameters with thegetParsedBodymethod, but it obviously shoudn't.The bug was introduced in #7052, the reason for the changes was to copy the JSON body, but query parameters was copied as well.
The same issue in #22805 and #17087.
There might be misusing of this field due to the long presence of this bug (from 4.2), maybe it is better to fix it in master?