Skip to content

[12.x] Add URL signature macros to Request docblock #56230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

[12.x] Add URL signature macros to Request docblock #56230

merged 1 commit into from
Jul 7, 2025

Conversation

duncanmcclean
Copy link
Contributor

While source diving, I noticed that the FoundationServiceProvider registers four URL signature related macros, however, the Request docblock only includes one of them.

This PR adds the other three to the docblock:

  • hasValidRelativeSignature
  • hasValidSignatureWhileIgnoring
  • hasValidRelativeSignatureWhileIgnoring

@taylorotwell taylorotwell merged commit e57ee26 into laravel:12.x Jul 7, 2025
62 checks passed
@duncanmcclean duncanmcclean deleted the add-url-signature-macros-to-request-docblock branch July 7, 2025 15:01
mohammad-fouladgar pushed a commit to mohammad-fouladgar/framework that referenced this pull request Jul 22, 2025
@duncanmcclean @mohammad-fouladgar
Add URL signature macros to Request docblock (laravel#56230)
1d64923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanmcclean @taylorotwell