Skip to content

[5.0] Enclose PostgreSQL schema name with double quotes #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2015
Merged

[5.0] Enclose PostgreSQL schema name with double quotes #8394

merged 1 commit into from
Apr 12, 2015

Conversation

efecan
Copy link
Contributor

@efecan efecan commented Apr 12, 2015

Schema names must be enclosed with double quotes to prevent PDOException while setting search path to an alphanumerical value. Following exception is from a production environment (v4.2.17). (Note that the first id is a trimmed version of the second id)

[PDOException]
SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near "d959d1fa9f6f2831c1d13ff05baed"
LINE 1: set search_path to 397d959d1fa9f6f2831c1d13ff05baed

@GrahamCampbell
Copy link
Member

Tests failed.

@GrahamCampbell GrahamCampbell changed the title Enclose PostgreSQL schema name with double quotes [5.0] Enclose PostgreSQL schema name with double quotes Apr 12, 2015
Schema names must be enclosed with double quotes to prevent PDOException while setting search path to a alphanumerical value. Following exception is from a production environment (v4.2.17). (Note that the first id is trimmed version of the second id)

  [PDOException]
  SQLSTATE[42601]: Syntax error: 7 ERROR:  syntax error at or near "d959d1fa9f6f2831c1d13ff05baed"
  LINE 1: set search_path to 397d959d1fa9f6f2831c1d13ff05baed
@efecan
Copy link
Contributor Author

efecan commented Apr 12, 2015

OK fixed it.

taylorotwell added a commit that referenced this pull request Apr 12, 2015
[5.0] Enclose PostgreSQL schema name with double quotes
@taylorotwell taylorotwell merged commit 6cf6dfc into laravel:5.0 Apr 12, 2015
@efecan
Copy link
Contributor Author

efecan commented Apr 14, 2015

Will this fix be included in the 4.2 branch too?

@GrahamCampbell
Copy link
Member

@efecan No. 4.x is not supported, and will only be receiving security fixes.

@efecan
Copy link
Contributor Author

efecan commented Apr 14, 2015

I think this is a blocker fix. For our case we need to switch to a custom composer install with this commit cherry-picked.

@laravel laravel locked and limited conversation to collaborators Apr 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants