Skip to content

Fix forum overview sort order #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Fix forum overview sort order #800

merged 4 commits into from
Jan 5, 2022

Conversation

joedixon
Copy link
Contributor

@joedixon joedixon commented Jan 5, 2022

This PR resolves #792

There were a couple of issues here which, when combined, caused the strange sorting issues on the frontend.

  1. The last_activity_at timestamp was not being updated when a new thread was created as it was not a fillable field.
  2. Although it was not possible to add a new reply to an old thread from the UI (button is removed from the page), it was still possible to manually create a POST request to the /replies endpoint. I added validation to prevent this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Sorting order?
3 participants