phpspec 5.0 support #35
Conversation
|
Any change @ek9 of merging this in + new release? phpspec 5.0 was released yesterday |
composer.json
Outdated
| @@ -25,7 +25,7 @@ | |||
| }, | |||
| "require": { | |||
| "php": "^7.1", | |||
| "phpspec/phpspec": "^4.2", | |||
| "phpspec/phpspec": "^4.2|^5.0", | |||
|
Any news about that? |
|
@roukmoute temporary workaround until it get merged, we can define in composer.json my repository fork: "require-dev": {
// ...
"leanphp/phpspec-code-coverage": "dev-patch-1"
// ...
},
"repositories" : [
{
"type" : "vcs",
"url" : "https://github.com/samsonasik/phpspec-code-coverage",
"no-api": true
}
] |
|
Yep thanks, this is what I've done. |
|
@samsonasik I think you could do a temporary valid packagist waiting for it to unlock here. |
|
Any news on this? |
|
The PR seems valid. According to the phpspec changelog there shouldn't be any BC breaks apart the PHP version bump. But @ek9 hasn't been active on github since July 2018, so I guess there's isn't much hope of having this accepted soon. That's quite a long github break btw., I really hope everything is fine with him/her! |
|
The domain ek9.co seems to have expired 2018-10, which makes me think nothing will happen here. The only other person I see in the commit history is @Seldaek, so perhaps he can shed some light on what is going on. |
|
Sorry but I have no idea what this project even is, I merely submitted a PR to remove a link because I got a warning for it on packagist.org support. |
|
@sp-felix-carmona or @UFOMelkor do you have write access? It seems @ek9 is rather inactive |
|
So if anyone else is interested I decided to fork this and add my fork to Packagist. I updated it for ^5.0 as well so at least until this one comes back to life you are all welcome to use it. |
|
@Dragonrun1 if you're planning to maintain this bundle, consider tagging new version (to make it stable) & allowing to submit issues ;) |
|
I don't have a lot of time to do any real package maintenance but since I do use it a lot I thought I'd try to help some other people out a little while I was at it. I'll look at doing a new tagged version in next couple days and if people have PRs I'll look at them as well as I have time. I've got a lot of other projects going right now so I wasn't looking at adding a new one ;) |
|
Hello @Dragonrun1 ! It's really cool to have published a new packagist version. Since you haven't enough time to work on that lib, what do you think to move it under an organization with multiple maintainer in it ? It'll just allow to have more people behind the lib and avoid the same issue that we had on this one 😄. Personnaly, I can take some time to maintain this one. |
|
@shulard |
|
@shulard @Dragonrun1 I thought about using the existing phpspec organization for maintaining this package. See phpspec/phpspec#1245. If the phpspec-maintainers are willing to take this repository in, we wouldn't have to create a separate organization. Otherwise the plan with the organization seems like a good idea. 👍 |
|
Hello @jaylinski ! You're absolutely right, if we can move that repository in the main phpspec organization, it'll help a lot. Let see what they think about it. |
Seems they are inactive too... 🙄 |
|
please ! we need this one ! |
|
Any update? We need it as well. |
|
Well the build job is failing. So we might need to fix that first. |
|
The travis build failure in php 7.2 env is nothing todo with the changes. It was travis issue. |
|
Ah then they need to restart the job. |
Turns out they don't like the idea... |
|
Sorry I've been busy with school etc but finally, have a little time to try to move at least the merge forward. |
|
Sorry thought this was on my fork guess not but while I'm here if there are any other ideas on improving the project I might have a little time right now to look into working on some stuff so ideas are welcome. |
|
Based on #38 , there is now a fork that support PHPSpec 5: https://packagist.org/packages/drupol/phpspec-code-coverage |
|
as phpspec doesn't want it and the maintainer is away from github since more than a year, i think it is time for this library to find a new home. |
|
I’l not sure about solid maintaining capabilities but I’ll be glad to help ;-) To avoid the same issue with the only commiter/owner who left the project, I think the best is to create an organisation like phpspec-extension. Maybe we’ll have the chance to aggregate multiple extension maintainers in it... WDYT ? |
|
I'll be glad to help maintaining the fork I did. |
|
@drupol thank you for the fork but what do you think about the organisation ? Because it’s always better to not rely on individuals directly for such things... Won’t it be better to add you as a maintainer on the org repo ? Your version is currently the more advanced one so we can start working from that version if you want ? |
|
Also for the communication and share relying on the phpspec-extensions name can be clearer and help being more confident with the support... |
Definitely. I'll be glad to do so. |
|
|
|
Glad to hear this and yes the org name can be updated :-) Same on my side limited access to the web until Friday but we’ll discuss this ASAP. |
|
@shulard Thanks for taking the lead on this. I'm also happy to help as a org maintainer. |
|
Hello guys ! Little update, the org was renamed You can visit the org here: https://github.com/friends-of-phpspec @drupol, @jaylinski you have been added as member of the org and you have access to the repository. I'll create some issues / PR to be sure that everything will be migrated. |
|
Hello everyone ! I'm glad to announce that I've just published a new official release of this package from the new friends of PHPSpec organization ! If you want a revamped and maintained version (compatible with PHPSpec 5.0), update your composer.json and move forward 😉. https://packagist.org/packages/friends-of-phpspec/phpspec-code-coverage Currently, everything is compatible so a quick composer.json update will make it works smoothly... |
|
@shulard thank you, I can close it ;) |
|
@Dragonrun1, if you still don't want to maintain your own release of this package, can you mark it abandoned on packagist in favor of the new one ? |
|
I'll look at updating my fork today. And have done so with a link to the new version. |
No description provided.