Ease deployment of LibGit2Sharp based web sites

[nulltoken]

Tweak LibGit2Sharp nuget package tooling so that it plays nice with Visual Studio Publishing mechanism. As a nice effect, this would also fix projectkudu/kudu#943

/cc @davidebbo @MattDavies

[sitereactor]

@nulltoken Is this with regards to the current way of handling the NativeBinaries via nuget? If so I believe I can help with an updated nuspec and targets/props build as we had to deal with this in a web app deployed via TeamCity. The issue we encountered sounds similar to that issue reported for kudu.

[nulltoken]

@sitereactor Yes it is. Eventually, I'd really like if we could only rely on targets/props and get rid of the *.ps1 scripts (see #425 that was a very early draft of this, but which wasn't Publish compliant AFAICT).

[sitereactor]

Okay, cool. Pretty sure I can help out with that as we've just been through something similar for the latest release of Umbraco (ref. github.com/umbraco/Umbraco-Cms).

I'll post back when I have something to show ;-)

[nulltoken]

Awesome! Thanks a lot for giving a hand here ❤️

[sitereactor]

Okay, so just wanted to give a bit of feedback before sending a pull request for this.
I've got this all working using a bit of a hack to run entirely off targets/props that can be included with nuget. But copying/moving the NativeBinaries folder from the project where the nuget is installed to the project that is either the main application (or web application) is quite challenging. So what I've done is to trick the main project (the one that is being built) to include the NativeBinaries in the build output and the only way to do that is to copy the NativeBinaries folder to the root of the project where the nuget is installed. And the catch is that the folder can't be removed from the root during build as it won't be able to complete.

Given these two projects:
GitLibrary - just a regular class library with LibGit2Sharp nuget installed.
WebApplication - an MVC application

When building the web app, the build will copy the NativeBinaries to the root of the GitLibrary project folder, which enables the WebApplication to include that folder in its output directory. But that also means that the result of the build will be as follows:
GitLibrary
-- bin\Debug\NativeBinaries*
-- bin\Release\NativeBinaries*
-- NativeBinaries*
WebApplication
-- bin\NativeBinaries*

Because of how msbuild works I have not been able to find a way to delete the NativeBinaries folder from the root of the project where LibGit2Sharp is installed after the copy to the output directory has completed. Adding a target to delete the folder AfterBuild also seems to run prior to the main application (the web app from above) having done its copy.

I hope this all makes sense. I'm happy to simply push the pull request if that can provide some more insight.

PS: I've added targets/props to support web deploy as well.

[nulltoken]

@sitereactor Awesome! 😍

I'm happy to simply push the pull request if that can provide some more insight.

Let's go this way. Once the PR is live, I'll try to some find some 👀 in order to help us with this.

[sitereactor]

@nulltoken coolio, PR summitted here #700
Happy to discuss further if anyone has additional input on how to solve the quirk of having a NativeBinaries folder in the root of csproj.

[nulltoken]

Fixed in #821

[itsananderson]

👍