Deleted remote branches remain when Fetch

[sergiodebst]

When you perform a Fetch, if in the origin have been added new branches, these branches are correctly added to the local Repository, however, if in the origin have been deleted any branches, these branches remain in the local Repository

[dahlbyk]

We don't currently support git fetch --prune, and libgit2/libgit2#1179 suggests libgit2 doesn't yet either.

[sergiodebst]

Ok and... Do you know a way to check this better than remove all remote branches before Fetch?

[carlosmn]

Note that keeping deleted branches on a "normal" fetch is correct Git semantics. Pruning deleted branches is only done at the user's explicit request.

[sergiodebst]

Note that keeping deleted branches on a "normal" fetch is correct Git semantics. Pruning deleted branches is only done at the user's explicit request.

Then, maybe there could be a property in FetchOptions to prune when available

[jamill]

Then, maybe there could be a property in FetchOptions to prune when available

I like this idea

[dahlbyk]

👍 for FetchOptions.Prune

We should also respect "fetch.prune" and "remote.*.prune" configuration variables, as added in Git 1.8.5. Ideally via libgit2.

[nulltoken]

Would be partially dealt with through #925.

[dahlbyk]

Would be partially dealt with through #925.

Partially? Looks like git_remote_prune was included, too, unless I'm missing something.

[nulltoken]

@dahlbyk Is far as I understood it, FetchOptions.Prune would be an "on-the-fly" request to prune without altering (or relying on) the configuration. Do I read this wrong?

[dahlbyk]

I read the same as you, which is how I understand git_remote_prune to work:

The remote object has learnt to prune remote-tracking branches. If the remote is configured to do so, this will happen via git_remote_fetch(). You can also call git_remote_prune() after connecting or fetching to perform the prune.

So in addition to the config-related changes proposed by #925, we should be able to support:

• FetchOptions.Prune { get; set; }
• Network.Prune(Remote)

[carlosmn]

Network.Prune(Remote) would just be a call to git_remote_prune(), but we don't allow setting the option on a git_remote as we do not have the code to persist it to disk.

[nulltoken]

[...] we don't allow setting the option on a git_remote as we do not have the code to persist it to disk.

@carlosmn What if we wanted to set it against the in-memory remote? ie. request for this specific Fetch() to prune the stale remote tracking branches, without persisting anything to disk?

[dahlbyk]

@carlosmn What if we wanted to set it against the in-memory remote? ie. request for this specific Fetch() to prune the stale remote tracking branches, without persisting anything to disk?

Wouldn't you just call git_remote_prune?

[carlosmn]

@carlosmn What if we wanted to set it against the in-memory remote? ie. request for this specific Fetch() to prune the stale remote tracking branches, without persisting anything to disk?

You can't do it.