-
Notifications
You must be signed in to change notification settings - Fork 903
odb_foreach() issue #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
odb_foreach() issue #487
Conversation
So, this is failing because:
@nulltoken has indicated there might be issues with this approach in mono. |
@@ -20,6 +20,16 @@ internal static unsafe class UnSafeNativeMethods | |||
[DllImport(libgit2)] | |||
internal static extern void git_strarray_free(ref git_strarray array); | |||
|
|||
internal delegate int git_odb_foreach_cb( | |||
ref GitOid id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the issue on Windows, not on Mono?
Thanks @jamill , it indeed fixes the test on Windows. The build still fails on Mono though. |
Opened a bug on the Mono issue tracker. |
/cc @joncham You've previously helped us with a Mono related bug. Did we mess up anyhow or does it look like a real issue to you? |
I'll take a look at it. |
The bug seems to be fixed on Mono side! I guess we can close this issue since we found a workaround. |
Fixed in mono/mono@e682ece @vargaz Thanks! ❤️ |
No description provided.