Skip to content

Support/1.x from master #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 23, 2020
Merged

Support/1.x from master #86

merged 10 commits into from
Oct 23, 2020

Conversation

goofballLogic
Copy link
Member

@goofballLogic goofballLogic commented Oct 9, 2020

I think I got everything but worth a check...

@goofballLogic goofballLogic requested a review from sblom October 9, 2020 15:51
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be great with a review from @sblom as well.

@goofballLogic
Copy link
Member Author

@asbjornu shall we go ahead and merge this?

Copy link
Member

@sblom sblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right.

@goofballLogic goofballLogic merged commit 8c0934b into support/1.x Oct 23, 2020
@asbjornu asbjornu deleted the support/1.x-from-master branch March 1, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants