Cherry-pick ecf93a716c9ecf2e38898547df90323e239a623c

[kadircet]

Bugzilla Link	50242
Resolution	FIXED
Resolved on	Jun 09, 2021 11:31
Version	unspecified
OS	All
Blocks	#48661
CC	@sam-mccall,@tstellar
Fixed by commit(s)	ecf93a7 84e8b1c

Extended Description

This is a privacy fix we missed in 12 release and would like to get it into point releases.

It was causing a merge conflict, for resolution you can check kadircet@4abdc83. Basically ignore the llvm::reverse in the for body.

[kadircet]

assigned to @sam-mccall

[tstellar]

Hi Sam,

What is your opinion on backporting this?

https://reviews.llvm.org/rG6329ce75da7a44c40d4406bf48ffffe973ef5fdb

[kadircet]

Hi Tom, sorry for the confusion here, but I was actually requesting cherry-pick of https://reviews.llvm.org/rGecf93a716c9ecf2e38898547df90323e239a623c. Hence the commit in my branch.

Updating the relevant fields.

[sam-mccall]

ecf93a7 LGTM.

For the default configuration (no grpc support, no remote index) it's effectively a no-op.

With grpc enabled, it provides better privacy in the default configuration.

We have unofficial clangd 12 binaries with grpc enabled that are fairly widely used, they have this commit cherrypicked and no problems with it reported.

[tstellar]

The fix does not apply cleanly, could someone backport this and push a branch to their local github fork?

[kadircet]

Hi Tom!

You can check kadircet@4abdc83.
Basically just ignore llvm::reverse inside the for statement.

[tstellar]

Merged: 84e8b1c