Convert APIs to use ArrayRef

[lattner]

Bugzilla Link	9214
Resolution	FIXED
Resolved on	Jul 26, 2011 01:59
Version	1.0
OS	All
CC	@jayfoad,@markus-oberhumer

Extended Description

Various LLVM APIs (such as the Constant*::get APIs, the GetElementPtrInst::Create methods, IRBuilder CreateGEP method, etc) that take multiple input values take std::vectors, and some now also can take a pointer to the start of an array and a count (for use with SmallVector). The new ArrayRef class subsumes both of these uses and is more convenient to use.

The implementation side of these should switch to use a FoldingSet (tracked by #1582 ), eliminating the temporary std::vector stored in various maps.

Also, ConstantExpr::getIndices() should be changed to return an ArrayRef.

[markus-oberhumer]

It seems the current version suffers from a copy-and-paste bug from StringRef.h - please try this patch.

~Markus

diff --git a/include/llvm/ADT/ArrayRef.h b/include/llvm/ADT/ArrayRef.h
index b016255..bc46e25 100644
--- a/include/llvm/ADT/ArrayRef.h
+++ b/include/llvm/ADT/ArrayRef.h
@@ -53,7 +53,7 @@ namespace llvm {
: Data(&OneElt), Length(1) {}

 /// Construct an ArrayRef from a pointer and length.

• /implicit/ ArrayRef(T *data, size_t length)

• /implicit/ ArrayRef(const T *data, size_t length)
  : Data(data), Length(length) {}

  /// Construct an ArrayRef from a SmallVector.
  @@ -85,7 +85,7 @@ namespace llvm {
  return Data[0];
  }

• /// back - Get the last character in the string.

• /// back - Get the last element.
  const T &back() const {
  assert(!empty());
  return Data[Length-1];
  @@ -95,7 +95,7 @@ namespace llvm {
  /// @​name Operator Overloads
  /// @{

• char operator[](size_t Index) const {

• T operator[](size_t Index) const {
  assert(Index < Length && "Invalid index!");
  return Data[Index];
  }

[lattner]

Done on mainline, please send patches to llvm-commits. Thanks!

[jayfoad]

I'm tackling some uses of std::vector in the APIs in Constants.h.

[jayfoad]

I've converted everything I could find in Constants.h, Instructions.h and IRBuilder.h to use ArrayRef. Is that enough to close this bug?

[lattner]

Yes! Please do, thanks again Jay!

[jayfoad]

Fixed, then.